[Fix][Android] Properly set the border color when there are round borders on Android#25649
Closed
cabelitos wants to merge 1 commit intofacebook:masterfrom
Closed
[Fix][Android] Properly set the border color when there are round borders on Android#25649cabelitos wants to merge 1 commit intofacebook:masterfrom
cabelitos wants to merge 1 commit intofacebook:masterfrom
Conversation
Drawing the border in one pass should only be done with the borderWidth and borderColor are the same for all directions (top, left, bottom and right), otherwise React may draw wrong colors. This commit adds a check to verify if all the colors are the same, otherwise it will draw each quadrilateral independently.
|
facebook-github-bot
approved these changes
Jul 15, 2019
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Contributor
Author
|
@mdvacca thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drawing the border in one pass should only be done with the borderWidth and
borderColor are the same for all directions (top, left, bottom and right),
otherwise React may draw wrong colors.
This commit adds a check to verify if all the colors are the same,
otherwise it will draw each quadrilateral independently.
Changelog
[Android] [Fix] - Properly paint the border colors and there are round borders
Test Plan
Using the code below one must see the correct border colors just like the example below:
Without the fix
Notice that the first rectangle does not have a transparent top bar and the third rectangle have all borders black
With the fix
All borders are properly colored.
Closes #25643